Skip to content

CLN: _convert_scalar_indexer only handle "loc" and "getitem" #31709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 7, 2020

Conversation

jbrockmendel
Copy link
Member

_convert_scalar_indexer is called with kind="iloc" from only one place, and in that case

  1. the base class method is equivalent to just the 1-liner self._validate_indexer("positional", key, "iloc")
  2. all subclasses just call the base class method

So by inlining that 1-liner, we can take the "iloc" case out of _convert_scalar_indexer altogether.

kind=None is never passed, so we can rip that right out.

Ultimately I want to disentable/de-duplicate/disambiguate _convert_scalar_indexer vs _maybe_cast_indexer

Partial overlap with #31625.

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 5, 2020
@jreback jreback added this to the 1.1 milestone Feb 6, 2020
@jreback
Copy link
Contributor

jreback commented Feb 7, 2020

can you rebase

@jbrockmendel
Copy link
Member Author

rebased+green

@jreback jreback merged commit 0d078c5 into pandas-dev:master Feb 7, 2020
@jbrockmendel jbrockmendel deleted the convert_scalar_indexer3 branch February 7, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants